Repository navigation
[FIX] button tests and tooling config alignment - #142
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns Button accessibility test expectations with the actual Button semantics, and brings the test/tooling configuration back into sync with the repository’s current folder layout and baseline TypeScript target (per issue #141).
Changes:
- Update Button tests to assert
role="button"(notrole="switch") foraria-pressedtoggle-button cases. - Fix Vitest
setupFilespath to use./tests/setup.ts(matching the repo’stests/directory). - Adjust
tsconfig.jsoncompiler target fromES2024toES2022.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
vite.config.ts |
Points Vitest setup to the existing tests/setup.ts file. |
tsconfig.json |
Lowers TS target to ES2022 to match the stated tooling baseline. |
src/components/atoms/button/Button.test.tsx |
Updates accessibility role expectations for aria-pressed cases to button. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
egdev6
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the current mismatch between Button accessibility test expectations and the project test/tooling configuration.
Closes #141
Type of change
Component checklist (skip if not applicable)
types.ts,use*.ts,Component.tsx,index.ts,*.stories.tsx)types.ts, not inlinetheme.cssanytypes — TypeScript strictHow to test
src/components/atoms/button/Button.test.tsxnow expectsrole="button"foraria-pressedcases.vite.config.tsuses./tests/setup.ts.tsconfig.jsontargetsES2022.Screenshots / recordings (if applicable)
No aplica.
Notes for reviewer